Skip to content

Conversation

im-coder-lg
Copy link
Contributor

Fixes #
Minor fix

@jsjoeio I have applied the changes(cdr to coder) to the links, user(in this case, org) and removed the extra comma in the README(code-server or Coder difference) that made me think it's not right.

This is ready for merge, however, should I run yarn fmt and rebase(before FMT of course) again?

@im-coder-lg im-coder-lg requested a review from a team January 20, 2022 08:22
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #4770 (b8a6f76) into main (51818dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4770   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files          29       29           
  Lines        1652     1652           
  Branches      363      363           
=======================================
  Hits         1143     1143           
  Misses        432      432           
  Partials       77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51818dc...b8a6f76. Read the comment docs.

@im-coder-lg
Copy link
Contributor Author

Also, an unrelated question - how did you enable Codecov?

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@jsjoeio jsjoeio merged commit 6e04501 into coder:main Jan 20, 2022
@jsjoeio jsjoeio added this to the 4.0.2 milestone Jan 20, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* docs: Change `cdr` to `coder`, read desc please

Yeah, includes links.

* docs: Update README (links and the extra comma)

Co-authored-by: Joe Previte <jjprevite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants